fix(ExAppNotifier): First check if any exapps enabled#614
Merged
nickvergessen merged 2 commits intomainfrom Oct 6, 2025
Merged
fix(ExAppNotifier): First check if any exapps enabled#614nickvergessen merged 2 commits intomainfrom
nickvergessen merged 2 commits intomainfrom
Conversation
To avoid unnecessary work and logs Signed-off-by: Marcel Klehr <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds an early guard clause in the prepare method to avoid unnecessary work and logs when no external apps are enabled.
- Introduces a check for an empty ExApps list and throws
UnknownNotificationExceptionif none are configured. - Retains existing behavior of throwing the same exception when a specific app is unknown.
Comments suppressed due to low confidence (1)
lib/Notifications/ExAppNotifier.php:39
- New behavior for an empty ExApps list should be covered by a unit test to ensure the exception is thrown as expected.
if (count($this->service->getExAppsList()) === 0) {
more performant Signed-off-by: Marcel Klehr <[email protected]>
Contributor
|
Is it just to hide the Because |
Member
Author
|
Yes |
oleksandr-nc
approved these changes
Jul 17, 2025
Contributor
|
another option - maybe we just remove that debug line? |
Member
Author
|
As you wish. I was trying to keep the behavioural change minimal :) |
Contributor
|
Of course, I prefer to remove this debug line (it's a less significant change), but I am happy with the current approach. |
andrey18106
approved these changes
Jul 17, 2025
nickvergessen
approved these changes
Oct 6, 2025
Collaborator
|
backports required? |
Member
|
32 would make deving easier on the most used systems |
Contributor
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary work and logs