feat: custom Docker registries support (only for docker-install type)#554
feat: custom Docker registries support (only for docker-install type)#554andrey18106 merged 2 commits intomainfrom
Conversation
|
And |
kyteinsky
left a comment
There was a problem hiding this comment.
looks nice!
But what do you think of making it just an override value that replaces any and all registries? Like value "local" could replace docker.io and ghcr.io, the from field would not be required. Right now we would have to check the info.xml file for the registry that the apps are using to put in the from value.
Let me know if I misunderstood something.
For some situations this will be not optimal. For example in some org, there will be only banned(or they will think that it is insecure) Then they can make a private registry only for one public registry and mirror only ExApps from it and leave other untouched. |
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
1a3db27 to
bc7d61f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
fair enough ✌️ |
This PR adds possibility to configure custom docker registry mappings.
Resolves: #530
In addition to UI there are 3 simple CLI commands added to manage daemon's custom registry mappings:
occ app_api:daemon:registry:addocc app_api:daemon:registry:removeocc app_api:daemon:registry:listRegistry mapping stored in Deploy daemon's
deploy_config.registries({from: string, to: string}[]).The mapping target
to="local"disables image pulling step, ExApp image name is not changed and retrieved frominfo.xmlas usually, assuming it was already pulled manually or built locally with the same name.In other cases image_src (registry domain) is replaced (e.g.
ghcr.io/repository/image_name -> docker.io/repository/image_name.Details