Fix parameter preparation for occ command#518
Merged
oleksandr-nc merged 1 commit intomainfrom Mar 4, 2025
Merged
Conversation
oleksandr-nc
requested changes
Feb 24, 2025
Contributor
oleksandr-nc
left a comment
There was a problem hiding this comment.
Was on vacation, sorry for the delay in replying.
And why is PR made in stable31 branch? Maybe it would be better to make it in main and backport it?
Contributor
|
@R0Wi good time of day. Are you willing to rebase this PR on |
Member
Author
|
Hi @oleksandr-nc, sorry for the delayed answer. Unfortunately I've been out sick last week. Happy to incorporate your review findings tonight 👍 |
* Fix for #517 Signed-off-by: Robin Windey <ro.windey@gmail.com>
275486f to
85d7934
Compare
Member
Author
|
@oleksandr-nc rebased on |
kyteinsky
approved these changes
Mar 3, 2025
oleksandr-nc
approved these changes
Mar 4, 2025
Contributor
|
/backport to stable31 |
Contributor
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
occcommandline paramsocccommand has been sent, nothing could be found in the logs)Notes
stable31$this->config->getSystemValue('apps_paths')with[], because I found some errors in my logs when trying to uninstall an app (something like "foreach needs an array, string given ..."). This happens ifapp_pathsis not set.getSystemValuewill return an "empty" string in that case.