Merged
Conversation
This was referenced Jan 17, 2025
andrey18106
force-pushed
the
feat/advanced-deploy-options
branch
from
895ca0b to
69e0e1b
Compare
kyteinsky
requested changes
Jan 20, 2025
Collaborator
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
nice, works great!
see some minor issues.
oleksandr-nc
approved these changes
Jan 20, 2025
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
I generally agree with Anupam's comments, and I'm giving my review in advance.
During backporting to the "stable31" branch CI will fail, so it is fine to merge with red CI to "stable31"
andrey18106
force-pushed
the
feat/advanced-deploy-options
branch
from
69e0e1b to
bd8b37f
Compare
Signed-off-by: Andrey Borysenko <[email protected]>
andrey18106
force-pushed
the
feat/advanced-deploy-options
branch
from
bd8b37f to
e27b687
Compare
Contributor
Author
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #406
Requires: nextcloud/server#50230