Skip to content

Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60.#430

Merged
bigcat88 merged 1 commit intomainfrom
fix/exapps-containers-stop
Oct 31, 2024
Merged

Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60.#430
bigcat88 merged 1 commit intomainfrom
fix/exapps-containers-stop

Conversation

@bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Oct 31, 2024

If ExApp is resource-heavy, stopping it now does not always free up resources (only if it is implemented in ExApp itself, which is quite rare)

That is why we add this PR to turn off the docker container when clicking the "disable" button on ExApp.

With "manual installation" - nothing changes, we have nothing to turn off and this is not supported.

Also, the timeout for a request to ExApp to turn on/off has been raised from 30 seconds to 60 seconds, which is still acceptable for UI so as not to seem slow;

Resolves: #410

…enable/disable increased to 60.

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Copy link
Member Author

/backport to stable30

@bigcat88 bigcat88 merged commit 92f2f87 into main Oct 31, 2024
@bigcat88 bigcat88 deleted the fix/exapps-containers-stop branch October 31, 2024 10:36
@backportbot
Copy link

backportbot bot commented Oct 31, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/430/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable30

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@bigcat88
Copy link
Member Author

/backport to stable29

@backportbot
Copy link

backportbot bot commented Oct 31, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/430/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable29

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

bigcat88 added a commit that referenced this pull request Oct 31, 2024
After the previous PR(#430) which added stopping application containers
feature when shutting down, as @andrey18106 correctly noted during our
1:1 conversation:

we cannot rely on the application inside the docker container to be
ready to process the request at the moment the docker container is
turned on.

This PR introduces handling of it by checking health-check and
heartbeat.

Signed-off-by: bigcat88 <bigcat88@icloud.com>
bigcat88 added a commit that referenced this pull request Oct 31, 2024
Added stopping of docker containers when ExApp is disabling. Timeout of
enable/disable increased to 60.

Manual backport of #430

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance "Disable App" Functionality to Fully Stop the App Container

2 participants