fix(AppAPIService): encode query parameter arrays via http_build_query#412
Merged
fix(AppAPIService): encode query parameter arrays via http_build_query#412
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
andrey18106
approved these changes
Oct 7, 2024
Contributor
andrey18106
left a comment
There was a problem hiding this comment.
LGTM, better also to double check within the issue to confirm it works as expected now.
3 tasks
bigcat88
approved these changes
Oct 8, 2024
Member
bigcat88
left a comment
There was a problem hiding this comment.
let's merge this and request backports.
I'll test it heavily this week with Flow and Visionatrix, after that we can approve & merge backports.
Member
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/412/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2b307976
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/412/stable29Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Oct 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #384. If the checks still pass and this gets merged, perhaps we should take a look at other apps to see if they need to be updated in the same way.