Conversation
|
Thanks for the pull request, it's good, but there are a couple of small inaccuracies that will be good to be fixed:
|
|
Aah yes, thank you, I will look into that tomorrow! |
57a9ece to
23f79a2
Compare
5988bcc to
e3bd4f6
Compare
e3bd4f6 to
64a8d39
Compare
|
It seems there are some syntax errors in new components (missing prop, error prop type check) in console while opening daemon selection - I don't see the list of daemons to choose from (I have one manual-install and one docker-install daemon). |
|
Then you shouldn't see the list as it's only one valid daemon. Can you check with two docker-install? Edit: ah damn, I see what you mean, will check |
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
c1840be to
95f67d1
Compare
|
Should be fixed, but something in my NC instance seems broken right now and I cannot validate. I will try to fix it and check, feel free to check yourself or wait :) |
|
Works! |
Signed-off-by: janepie <jana@stormy-stories.surf>
Signed-off-by: janepie <jana@stormy-stories.surf>
|
Totally, both points done :) |
bigcat88
left a comment
There was a problem hiding this comment.
Thank you for putting effort on this, great job.
|
now it’s up to you, Andrey, when we will combine this and whether we will make adjustments on our part. |



Resolves #276
I had to prolong the waiting time for the registering as (at least on my setup) it took 15-20 sec (also when done per occ command directly, I checked)
Did not comment the Vue parts as you don't seem to use comments there. If I should add comments just let me know!