Conversation
tobiasKaminsky
force-pushed
the
sharingPart2
branch
3 times, most recently
from
f98ce16 to
8349807
Compare
|
Let us see what CI and rest are saying, then I squash and set it to review. |
tobiasKaminsky
force-pushed
the
sharingPart2
branch
from
bf6f65f to
be357db
Compare
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
sharingPart2
branch
from
bafc59d to
c8a49d9
Compare
|
After checks passing, I will rebase it |
…ip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: Torsten Grote <t@grobox.de>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Add auto-approve for dependabot
Update DocumentsProvider roots when enabling/disabling app lock feature
… [skip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
|
Issues
======
+ Solved 3
- Added 3
Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/ui/adapter/NewLinkShareViewHolder.java 1
- src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.java 3
- src/main/java/com/owncloud/android/ui/adapter/ShareViewHolder.java 7
- src/main/java/com/owncloud/android/ui/adapter/InternalShareViewHolder.java 2
- src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.java 3
Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/operations/UpdateShareViaLinkOperation.java -1
+ src/main/java/com/owncloud/android/ui/adapter/ShareeListAdapter.java -5
+ src/main/java/com/owncloud/android/services/OperationsService.java -1
See the complete overview on Codacy |
| public void onDestroy() { | ||
| super.onDestroy(); | ||
| unbinder.unbind(); | ||
| binding = null; |
There was a problem hiding this comment.
Codacy found an issue: Assigning an Object to null is a code smell. Consider refactoring.
| import static com.owncloud.android.lib.resources.shares.OCShare.SHARE_PERMISSION_FLAG; | ||
| import static com.owncloud.android.lib.resources.shares.OCShare.UPDATE_PERMISSION_FLAG; | ||
|
|
||
| public class FileDetailSharingFragment extends Fragment implements ShareeListAdapterListener, |
There was a problem hiding this comment.
Codacy found an issue: Possible God Class (WMC=99, ATFD=285, TCC=25.371%)
| @Override | ||
| public void onDestroyView() { | ||
| super.onDestroyView(); | ||
| binding = null; |
There was a problem hiding this comment.
Codacy found an issue: Assigning an Object to null is a code smell. Consider refactoring.
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15927.apk |
|
stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15927-Screenshot-stable-light-blue |
|
master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15927-Screenshot-master-light-blue |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15927-IT-stable |
|
Let us get it in 👍 |
Sharing part2 Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
4 participants
Fix #6427
Fix #6321
Currently stale as release 3.13 with E2E is more important.
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests