Show/Hide auto upload list items

[AndyScherzinger]

Resolves #3263

TODO

• if all folders have been hidden, empty view gets trigger (no way to toggle visibility on list anymore)
• show/hide adapter flag to be fixed
• display of visibility list toggle (footer) to be fixed
• show action when all items have been hidden Show/Hide auto upload list items #4784 (comment)

Empty view in case all folders have been hidden before

List in case a folder is hidden (clicking the footer will show the hidden folders)

List with "show all" state

Menu of a (originally) hidden item in case you choses to show all items

Menu of a visible item

[AndyScherzinger]

@jancborchardt @nextcloud/designers I need some feedback/input on how to better hadnle certain things when it comes to show/hide items in the auto upload list. This PR adds this feature and does it as discussed in #4331 (comment) and #4331 (comment).

Summarizing the issues I am having (UI/UX wise at the moment)

• there is no clear signed that the list is filtered/unfiltered (there is a footer in case you open the list and the list is filtered, else you don't have a footer --> not easy to discover)
• you can't really toggle the filter-state of the list (you can only show hidden folders, then the footer magically disappears since there is nothing else to show on top, the only way to hide elements from the list is to navigate away and back to auto uploads...)
• you can toogle show/hide on an item while the text is dynamic (action-based), so in case you have hidden items and hit the footer to show hidden items, the item is visible while the menu text says "show item" while this reflects the general visibility state it conflicts with the lists filter state.
• In case all items have been hidden I show a special empty view with an action button to show the items (temporarily)

Looking at the description this all seems complex even to describe. I believe we can do better here 😃

So here are the screenshots 🖼 to give you an idea 💡 what I am talking 💬 about.

Empty view in case all folders have been hidden before (hidden folder info is kind of duplicated here...)

List in case a folder is hidden (clicking the footer will show the hidden folders)

List with "show all" state

Menu of a (originally) hidden item in case you choses to show all items

Menu of a visible item

Possible solutions

• always show the footer and mirror the state (text to be discussed): "Show x hidden folders" / "Hide folders"
• Add a checkbox to the menu item and use the text "hide item" (that way the state is clear (kind of fits how we display can read/edit/delete in the file details screen on Android and web
• Also: If and how could hidden/non-hidden tems be distinguished within the list? (in case we want that)

[codecov]

Codecov Report

Merging #4784 into master will increase coverage by 0.15%.
The diff coverage is 16.57%.

@@             Coverage Diff              @@
##             master    #4784      +/-   ##
============================================
+ Coverage     17.58%   17.74%   +0.15%     
  Complexity        3        3              
============================================
  Files           384      384              
  Lines         32528    32650     +122     
  Branches       4588     4597       +9     
============================================
+ Hits           5720     5793      +73     
- Misses        25887    25931      +44     
- Partials        921      926       +5

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	84.61% <ø> (ø)	0 <0> (ø)	⬇️
...oud/android/datamodel/SyncedFolderDisplayItem.java	50% <ø> (ø)	0 <0> (ø)	⬇️
...ncloud/android/datamodel/SyncedFolderProvider.java	11.66% <0%> (-0.2%)	0 <0> (ø)
.../dialog/SyncedFolderPreferencesDialogFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...droid/ui/dialog/parcel/SyncedFolderParcelable.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...n/java/com/owncloud/android/jobs/FilesSyncJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	21.6% <0%> (-0.24%)	0 <0> (ø)
...ncloud/android/ui/adapter/SyncedFolderAdapter.java	13.14% <13.97%> (-1%)	0 <0> (ø)
...a/com/owncloud/android/datamodel/SyncedFolder.java	51.51% <28.57%> (+1.51%)	0 <0> (ø)	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	26.81% <30.4%> (+5.01%)	0 <0> (ø)	⬇️
... and 9 more

[jancborchardt]

Alright! Only have 2 pieces of feedback:

The emptycontent view could do without a button, instead the subline just saying "Show 2 hidden folders", then it’s consistent, doesn’t duplicate, and doesn’t call to attention what someone hid in the first place.

Add a checkbox to the menu item and use the text "hide item" (that way the state is clear (kind of fits how we display can read/edit/delete in the file details screen on Android and web

Yes please, that makes it more obvious. I was a bit confused when I saw the screenshot with the menu open saying "Show folder" cause it was already shown.

[AndyScherzinger]

Thanks for the feedback @jancborchardt ❤️

fixed

[AndyScherzinger]

@tobiasKaminsky @ezaquarii all your review comments have been fixed, thanks for the review. Would you mind giving it another look / test drive? 🙏

@ArisuOngaku Since you made some changes to these files recently and I had to resolve some larger conflicts due to the fact that I moved some code around I'd appreciate if you could also have a look so I don't break your recent changes (which I shouldn't have, but one never knows...) ❤️

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11769.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 1
           

Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.java  2
- src/main/java/com/owncloud/android/providers/FileContentProvider.java  3
- src/main/java/com/owncloud/android/ui/dialog/parcel/SyncedFolderParcelable.java  2
         

See the complete overview on Codacy

[nextcloud-android-bot]

Issue found: Assigning an Object to null is a code smell. Consider refactoring.

[nextcloud-android-bot]

Codacy

333

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	104
Security Warnings	44
Dodgy code Warnings	136
Total	407

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	26
Correctness Warnings	70
Internationalization Warnings	13
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	117
Security Warnings	44
Dodgy code Warnings	134
Total	418

[ashpieboop]

@AndyScherzinger everything looks fine regarding my PR. You only modified lines (files) in a way that can't undo my fix. I see no regression! :)

[AndyScherzinger]

Thanks a lot @ArisuOngaku ❤️ Highly appreciate you taking a look 🎉

[tobiasKaminsky]

Nice, let us merge this :-)

But I have some things, which we can do in new PRs, if approved:

• change "show x folders" in bottom to "temporary show x 4 folders" as they are gone when re-opening the auto upload view
• overlay menu looks a bit big (in height)?
  
• position of checkbox looks a bit off