Sharees will be in NC17

[tobiasKaminsky]

Needs:

• Show sharees via propfind server#14429

Needs:

• Change sharees format android-library#325

TODO:

• test transition of dev client before merging, as prevously userId as string was saved, but now gson seralized as string -> conflict
• test with old server

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10193

[codecov]

Codecov Report

Merging #4284 into master will decrease coverage by 0.7%.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##             master    #4284      +/-   ##
============================================
- Coverage     16.81%   16.11%   -0.71%     
  Complexity        1        1              
============================================
  Files           358      340      -18     
  Lines         31788    31198     -590     
  Branches       4490     4430      -60     
============================================
- Hits           5345     5026     -319     
+ Misses        25544    25307     -237     
+ Partials        899      865      -34

Impacted Files	Coverage Δ	Complexity Δ
...a/com/owncloud/android/utils/FileStorageUtils.java	20.29% <100%> (+0.19%)	0 <0> (ø)	⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java	23.62% <100%> (+1.5%)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	64.67% <100%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	31% <7.14%> (+1%)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	36.41% <83.33%> (+0.13%)	0 <0> (ø)	⬇️
...java/com/nextcloud/client/appinfo/AppInfoImpl.java	50% <0%> (-16.67%)	0% <0%> (ø)
...tcloud/client/network/ConnectivityServiceImpl.java	55.55% <0%> (-3.77%)	0% <0%> (ø)
...ncloud/android/ui/adapter/ActivityListAdapter.java	0% <0%> (-3.67%)	0% <0%> (ø)
...xtcloud/client/account/UserAccountManagerImpl.java	47.27% <0%> (-2.73%)	0% <0%> (ø)
...n/java/com/nextcloud/client/device/DeviceModule.kt	83.33% <0%> (-2.39%)	0% <0%> (ø)
... and 50 more

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10558.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[tobiasKaminsky]

/backport to stable-3.8

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10558

[nextcloud-android-bot]

Codacy

286

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	110
Security Warnings	46
Dodgy code Warnings	138
Total	412

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	110
Security Warnings	46
Dodgy code Warnings	138
Total	412

[backportbot-nextcloud]

backport to stable-3.8 in #4366