Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
approved these changes
Jul 22, 2019
tobiasKaminsky
added a commit
that referenced
this pull request
Jul 24, 2019
5370493 Merge pull request #4254 from nextcloud/clearInputBeforeQR 011169d reset host when using login via QR/link a65d1dd Merge pull request #4253 from nextcloud/fixMaster e9b0684 remove leftover 6a925b7 wip fc01e97 wip ac3a6d5 reformat imports kotlin: do not use wildcard imports 4c5eca9 remove leftovers from bottom bar removing 040b460 show "shared" again (#4249) 1064463 Bump ktlint from 0.34.0 to 0.34.1 (#4252) eb68c36 wip a1477a1 daily dev 20190723
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is something where our tests failed:
Unit tests on library, searching/listing shared works.
But the problem was in UI in our app.
I'll try now to catch this via in UI test.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me