OCFileListFragment: Only scroll to top if directory changed#4058
Merged
tobiasKaminsky merged 2 commits intomasterfrom May 23, 2019
Merged
OCFileListFragment: Only scroll to top if directory changed#4058tobiasKaminsky merged 2 commits intomasterfrom
tobiasKaminsky merged 2 commits intomasterfrom
Conversation
Signed-off-by: Unpublished <unpublished@gmx.net>
Codecov Report
@@ Coverage Diff @@
## master #4058 +/- ##
============================================
- Coverage 12.71% 11.73% -0.98%
Complexity 1 1
============================================
Files 329 329
Lines 30998 31000 +2
Branches 4424 4425 +1
============================================
- Hits 3940 3637 -303
- Misses 26394 26733 +339
+ Partials 664 630 -34
|
tobiasKaminsky
requested changes
May 23, 2019
src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
Outdated
Show resolved
Hide resolved
src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
Outdated
Show resolved
Hide resolved
Member
|
@Unpublished thanks for the finding of this, I did not thought about it 🎉 |
Signed-off-by: Unpublished <unpublished@gmx.net>
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9392.apk |
Collaborator
Codacy297Lint
SpotBugs (new)
SpotBugs (master)
|
Member
|
Tested and working 👍 |
tobiasKaminsky
approved these changes
May 23, 2019
Member
|
Thank you very much @Unpublished 🎉 🎉 🎉 |
Contributor
Author
|
/backport to stable-3.6 |
|
backport to stable-3.6 in #4062 |
Contributor
Author
|
Oh it works 😄 |
tobiasKaminsky
added a commit
that referenced
this pull request
May 24, 2019
3b31841 Merge pull request #3969 from nextcloud/receivePushDelete 6074c93 Drone: update FindBugs results to reflect reduced error/warning count [skip ci] f28007e OCFileListFragment: Only scroll to top if directory changed (#4058) b061e4d Merge commit '51ee4d88fd0555a945a24b1ab3beba2ffdc79c06' 51ee4d8 handle silent delete/delete-all push notifications do not ignore talk messages (will only be sent if no talk app is installed) exclude generated Parcelable fb6b11f Use product name on rich document, if available (#3971) 4197d3b use proper qa build lib dependency 8c06097 Only compare directories if necessary 403a3e0 Use product name on rich document, if available use placeholder for string reset to master-snapshot fix analysis warning use new translatable string use var vor qa flavor too 9b0a789 Merge pull request #4040 from nextcloud/ezaquarii/remove-findbugs d6b4dee Remove legacy FindBugs tasks from build script 53c9c05 daily dev 20190523
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes jumping to top everytime the listview is updated, since 3.6.1.
TODO