Conversation
59aaa40 to
3f5410e
Compare
Collaborator
Author
|
Discussed in #3620 |
Collaborator
Author
I don't see any increase here. |
Member
true - what is the value in the results file in the code-base I think @tobiasKaminsky bumped thee value to 497 after the latest lib version bump of spotbugs. |
Member
|
see #3955 |
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9015 |
Closes #3620 Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
3f5410e to
fd9f9a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #3960 +/- ##
===========================================
- Coverage 6.58% 6.57% -0.01%
Complexity 1 1
===========================================
Files 322 322
Lines 30908 30908
Branches 4408 4408
===========================================
- Hits 2035 2032 -3
- Misses 28577 28578 +1
- Partials 296 298 +2
|
Collaborator
Codacy277Lint
SpotBugs (new)
SpotBugs (master)
|
Collaborator
Codacy277Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
May 6, 2019
Member
|
Rebase FTW - @tobiasKaminsky since it is just the addition of kotlin support I'll merge so @ezaquarii can move forward :) |
Member
|
Cool, looking forward to it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Kotlin support would allow us to start deprecating Lombok and start using Kotlin in unit tests.
It is worth mentioning that Kotlin data classes provide compile-time generated
hashCode()andequals().Signed-off-by: Chris Narkiewicz hello@ezaquarii.com