Iteration 4 for File detail & new sharing - email share#2700
Merged
AndyScherzinger merged 7 commits intomasterfrom Jun 14, 2018
Merged
Iteration 4 for File detail & new sharing - email share#2700AndyScherzinger merged 7 commits intomasterfrom
AndyScherzinger merged 7 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2700 +/- ##
=========================================
+ Coverage 6.52% 6.53% +<.01%
=========================================
Files 285 285
Lines 28895 28896 +1
Branches 4210 4214 +4
=========================================
+ Hits 1885 1887 +2
Misses 26725 26725
+ Partials 285 284 -1
|
Member
Author
|
Strange, AS should have done this automatically, but anyways thanks @AndyScherzinger |
Member
Happy to help :) |
Member
10 tasks
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
21f3440 to
4ac524e
Compare
Contributor
Member
|
I vote for this to be backported 👍 3.2.1 |
24 tasks
Merged
|
Does this solve this issue? |
Member
|
No it solves the issue of correctly set permissions for mail shares. The one you are referring to solves the creation of mail shares. |
Member
|
My mistake, misread it, yes it does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to enter a valid email address and then share the file/folder to it.