Iteration 3 for file detail & new sharing by AndyScherzinger · Pull Request #2671 · nextcloud/android

AndyScherzinger · 2018-06-01T17:39:49Z

Iteration 1 can be found here: #2533 ☑️
Iteration 2 can be found here: #2573 ☑️

WiP for #2485

Add passwordProtected flag to OCShares android-library#149 merged
change back dependency to master-SNAPSHOTas soon as lib PR has been merged
ability to properly configure email shares

codecov · 2018-06-02T20:21:19Z

Codecov Report

Merging #2671 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2671      +/-   ##
=========================================
- Coverage    6.54%   6.52%   -0.02%     
=========================================
  Files         284     285       +1     
  Lines       28822   28895      +73     
  Branches     4197    4210      +13     
=========================================
  Hits         1885    1885              
- Misses      26653   26726      +73     
  Partials      284     284

Impacted Files	Coverage Δ
...fragment/util/FileDetailSharingFragmentHelper.java	`0% <ø> (ø)`	⬆️
...ain/java/com/owncloud/android/db/ProviderMeta.java	`88% <ø> (ø)`	⬆️
...ndroid/operations/UpdateShareViaLinkOperation.java	`0% <ø> (ø)`	⬆️
...android/ui/fragment/FileDetailSharingFragment.java	`0% <0%> (ø)`	⬆️
...cloud/android/ui/helpers/FileOperationsHelper.java	`0% <0%> (ø)`	⬆️
...wncloud/android/providers/FileContentProvider.java	`17.31% <0%> (-0.24%)`	⬇️
...id/operations/UpdateSharePermissionsOperation.java	`0% <0%> (ø)`	⬆️
...loud/android/datamodel/FileDataStorageManager.java	`10.57% <0%> (-0.04%)`	⬇️
...m/owncloud/android/ui/adapter/UserListAdapter.java	`0% <0%> (ø)`	⬆️
...m/owncloud/android/services/OperationsService.java	`0% <0%> (ø)`	⬆️
... and 3 more

AndyScherzinger · 2018-06-03T18:44:39Z

@tobiasKaminsky @mario to be discussed if this is the right approach. Atm my change would simply store a flag in the database if a share has a password but wouldn't store the password. This is imho the way to go while of course we could also store the password I simply wouldn't do that but have the user input a new password.
This is imho also how the webUI behaves, thus you can always change the password but you cannot recover the actual one.

tobiasKaminsky · 2018-06-04T10:15:59Z

Totally fine with it. Storing a password is not needed as you can always set a new one.

AndyScherzinger · 2018-06-05T16:50:50Z

@mario @ardevd @tobiasKaminsky please review :)

mario · 2018-06-09T12:12:15Z

src/main/java/com/owncloud/android/operations/UpdateSharePermissionsOperation.java

            share.setIsFolder(false);
        }
+
+        share.setIsPasswordProtected((mPassword != null && mPassword.length() > 0));


TextUtils.isEmpty(mPassword)? :)

nice catch! 🎉

Fixed via 723ec59

mario · 2018-06-09T12:13:14Z

One small comment.

mario · 2018-06-09T12:13:40Z

👍

AndyScherzinger · 2018-06-09T12:16:08Z

@tobiasKaminsky please review :)

…hare(mail) is password protected

tobiasKaminsky · 2018-06-12T07:20:28Z

Can you give me a quick guide how to share a file via email?

open up file detail
go to sharing
enter email address:

(on webUI, I see "test123@test.de (email)

AndyScherzinger · 2018-06-12T07:23:12Z

You can't atm, but you ate able to change existing ones regarding permissions and password. That didn't work before.

For actually creating new mail shares we need to find out how to do that...

tobiasKaminsky · 2018-06-12T07:27:18Z

👍
Editing existing email share is working 🎉

AndyScherzinger added the 2. developing label Jun 1, 2018

AndyScherzinger changed the title ~~Iteration 3: file details & sharing~~ Iteration 3 for file detail & new sharing Jun 1, 2018

tobiasKaminsky mentioned this pull request Jun 1, 2018

Roadmap: file detail & new sharing #2485

Closed

10 tasks

AndyScherzinger force-pushed the fileDetails-3 branch from 6ae260e to 35063f2 Compare June 2, 2018 20:21

nextcloud deleted a comment Jun 2, 2018

AndyScherzinger mentioned this pull request Jun 3, 2018

Iteration 4 for file detail & new sharing #2676

Closed

4 tasks

AndyScherzinger force-pushed the fileDetails-3 branch 2 times, most recently from 23f8e03 to 31e8da4 Compare June 4, 2018 13:16

nextcloud deleted a comment Jun 4, 2018

AndyScherzinger force-pushed the fileDetails-3 branch 3 times, most recently from e2e54c3 to 90b3b20 Compare June 5, 2018 14:43

AndyScherzinger added 3. to review and removed 2. developing labels Jun 5, 2018

AndyScherzinger mentioned this pull request Jun 5, 2018

Add passwordProtected flag to OCShares nextcloud/android-library#149

Merged

AndyScherzinger force-pushed the fileDetails-3 branch 4 times, most recently from 7745ef9 to 5fb05e2 Compare June 8, 2018 07:35

AndyScherzinger force-pushed the fileDetails-3 branch from 5fb05e2 to 32c4062 Compare June 9, 2018 11:46

mario reviewed Jun 9, 2018

View reviewed changes

AndyScherzinger requested a review from tobiasKaminsky June 9, 2018 12:16

AndyScherzinger force-pushed the fileDetails-3 branch 8 times, most recently from 7535188 to 1351397 Compare June 11, 2018 15:16

AndyScherzinger added 5 commits June 12, 2018 08:28

use lib branch with updated OCShare file

7e5655c

rewrite of sharing logic/persistence to store and use the fact if a s…

62a53dc

…hare(mail) is password protected

adding is_password_protected column for shares for initial DB setup

3cbec23

fix save of share is_password_protected single share persistence

1b22ead

Fix CR

29fcc56

AndyScherzinger force-pushed the fileDetails-3 branch from 1351397 to 29fcc56 Compare June 12, 2018 06:29

revert to master lib branch

62b85e4

tobiasKaminsky merged commit 6c12b57 into master Jun 12, 2018

tobiasKaminsky deleted the fileDetails-3 branch June 12, 2018 07:27

AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jun 12, 2018

AndyScherzinger mentioned this pull request Jun 23, 2018

Backport mail sharing #2715

Merged

AndyScherzinger removed the 3. to review label Aug 29, 2018

Uh oh!

Comments

Conversation

AndyScherzinger commented Jun 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AndyScherzinger commented Jun 3, 2018

Uh oh!

tobiasKaminsky commented Jun 4, 2018

Uh oh!

AndyScherzinger commented Jun 5, 2018

Uh oh!

mario Jun 9, 2018

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger Jun 9, 2018

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger Jun 9, 2018

Choose a reason for hiding this comment

Uh oh!

mario commented Jun 9, 2018

Uh oh!

mario commented Jun 9, 2018 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger commented Jun 9, 2018

Uh oh!

tobiasKaminsky commented Jun 12, 2018

Uh oh!

AndyScherzinger commented Jun 12, 2018

Uh oh!

tobiasKaminsky commented Jun 12, 2018 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndyScherzinger commented Jun 1, 2018 •

edited

Loading

codecov bot commented Jun 2, 2018 •

edited

Loading

mario commented Jun 9, 2018 •

edited by AndyScherzinger

Loading

tobiasKaminsky commented Jun 12, 2018 •

edited by AndyScherzinger

Loading