Merged
Conversation
8d9becf to
3ba3f9b
Compare
Member
Author
|
Once nextcloud/server#6876 is merged the problem should be solved as we then always have a bitmap. |
Member
|
nextcloud/server#6876 is merged :) |
213ce41 to
35ac7eb
Compare
Member
Author
|
nextcloud/server#6876 is independent from this PR as it is NC13 only. Annotated via custom annotation. The idea is that we can use this for tracking code parts which we can later remove. In this case, if min supported version is 13, we can safely delete this code. |
dae8b5d to
82d2de1
Compare
Contributor
|
Is this ready for review @tobiasKaminsky ? |
Member
Author
|
Yes. Do you want to have it in 2.1? |
Contributor
|
Yes
…On Thu, 11 Jan 2018 at 11:47, Tobias Kaminsky ***@***.***> wrote:
Yes. Do you want to have it in 2.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1658 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWskfR9Hkunx5DpAfSHFiE0RCRhqWTks5tJea6gaJpZM4P2iwS>
.
|
82d2de1 to
07b74b5
Compare
Member
Author
|
Then rebased and ready for review & test. |
d346f9d to
614d78b
Compare
added one more annotation Signed-off-by: tobiaskaminsky <tobias@kaminsky.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1566
This caches the etag of an avatar and sends the etag to server and gets
Edit: not query the server too often we could also implement a 15min timeout, or whatever time.