Fix crash when removing multiple favorites when in favorites tab

[JonasMayerDev]

When removing files from favorites on master, file gets deleted and calling notifyDataSetChanged gets scheduled. -> At some point, adapter does not know that file was deleted -> Crash when scrolling to point that should not be reachable since not enough items.

Details

2024-01-11 10:37:03.530 19840-19840 AndroidRuntime          com.nextcloud.android.beta           E  FATAL EXCEPTION: main
                                                                                                    Process: com.nextcloud.android.beta, PID: 19840
                                                                                                    java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 13(offset:13).state:14 com.owncloud.android.ui.EmptyRecyclerView{1bf0718 VFED..... ......ID 0,0-1080,2155 #7f0a02c6 app:id/list_root}, adapter:com.owncloud.android.ui.adapter.OCFileListAdapter@14690a6, layout:androidx.recyclerview.widget.LinearLayoutManager@21c3bf3, context:com.owncloud.android.ui.activity.FileDisplayActivity@4935eb7
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6752)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6688)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6684)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
                                                                                                    	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4604)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4307)
                                                                                                    	at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4873)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:689)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1103)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1841)
                                                                                                    	at android.widget.LinearLayout.layoutHorizontal(LinearLayout.java:1822)
                                                                                                    	at android.widget.LinearLayout.onLayout(LinearLayout.java:1584)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at com.google.android.material.appbar.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:149)
                                                                                                    	at com.google.android.material.appbar.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:43)
                                                                                                    	at com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:2348)
                                                                                                    	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
2024-01-11 10:37:03.530 19840-19840 AndroidRuntime          com.nextcloud.android.beta           E  	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1841)
                                                                                                    	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
                                                                                                    	at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
                                                                                                    	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
                                                                                                    	at com.android.internal.policy.DecorView.onLayout(DecorView.java:867)
                                                                                                    	at android.view.View.layout(View.java:23488)
                                                                                                    	at android.view.ViewGroup.layout(ViewGroup.java:6575)
                                                                                                    	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4119)
                                                                                                    	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3495)
                                                                                                    	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2416)
                                                                                                    	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9478)
                                                                                                    	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1242)
                                                                                                    	at android.view.Choreographer.doCallbacks(Choreographer.java:996)
                                                                                                    	at android.view.Choreographer.doFrame(Choreographer.java:886)
                                                                                                    	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1227)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:938)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:233)
                                                                                                    	at android.os.Looper.loop(Looper.java:344)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8248)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071) 

https://github.com/nextcloud/android/assets/43114340/0bd24014-8144-4317-8aad-652cdcf71ff9
Master

https://github.com/nextcloud/android/assets/43114340/114c8e1e-4f8d-4a52-ae80-2d14628b1264
This PR

• Tests written, or not not needed

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	69	69
Dodgy code	353	353
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	54	54
Security	18	18
Total	542	542

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12357.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[codecov]

Codecov Report

Merging #12357 (1043070) into master (5ec3f51) will increase coverage by 0.10%.
Report is 192 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #12357      +/-   ##
============================================
+ Coverage     27.77%   27.88%   +0.10%     
- Complexity     3214     3229      +15     
============================================
  Files           596      596              
  Lines         44582    44586       +4     
  Branches       6419     6420       +1     
============================================
+ Hits          12384    12434      +50     
+ Misses        30160    30100      -60     
- Partials       2038     2052      +14     

Files	Coverage Δ
...owncloud/android/ui/adapter/OCFileListAdapter.java	47.74% <0.00%> (+0.80%)	⬆️

... and 16 files with indirect coverage changes