Photo view: load new images when reaching bottom

[tobiasKaminsky]

Currently photo view tries to load all images that are stored on server and this results in very long waiting.
@rullzer had the idea to show first only the latest 7 days and when reaching the bottom of the list, then show/add again 7 days.
This would give the user at the beginning a very fast experience...

@mario it should be possible to limit the search to a certain timespan?

Well at first I think all the phones should take a long time to load but once they’ve all loaded there should be a solution that the app caches some of the data and remember the phones that where added, then if you add a new phone it will show up on the photos tab too do you understand what I’m saying?

[tobiasKaminsky]

The main problem is that displaying > 5000 images is just taking too long on internal android computing of the layout, resizing thumbnails, ...
Unfortunately this cannot be stored.

Retrieving all the infos from the server also takes some time, but is not that much in comparison.

Correct but the iOS system is doing it

[rullzer]

@andyxh this won't work in several setups.

• If you have a huge photo collection (I have a easily a few hunderd GB of pictures) the initial request will never finish. It will just time out.
• How will my phone find out there are new pictures that are uploaded for example with the desktop client? We'd have to query the server again. But we can't tell it just give us new stuff. Since the desktop client preserves mtime. So if you upload pictures from a month ago they will be sorted a month ago.

Long story short. Date range requests are an easy way to limit the request scope. While still providing the feeling of infinite scroll to the users.

Well when you click on the photos folder and when your scrolling throw the phone the picture show up and it keeps it cached, now can you take that cached data and show it in the photos tab ?

[weberbox]

How about a library to help load images in a better manner. I have used this before in a previous project. Not sure if it could help here as I have not reviewed any nexcloud code for image loading.

https://github.com/bumptech/glide

iOS has a photos tab option and once you click on the photos album and it loads all the photo tub nails you can go back into photos tab and it will show you all the photos. Not sure why android cant make something like this happen or talk to the iOS team on how they developed that feature.

…

Sent from my iPhone 7 Plus On Jan 5, 2018, at 11:23 PM, zippy-man <notifications@github.com<mailto:notifications@github.com>> wrote: How about a library to help load images in a better manner. I have used this before in a previous project. Not sure if it could help here as I have not reviewed any nexcloud code for image loading. https://github.com/bumptech/glide<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbumptech%2Fglide&data=02%7C01%7C%7C00746e822b0b4905f0c808d554c5961d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508129957260471&sdata=%2BX2FyfP62JnvV5vz5GmUgAiz%2BUN7ASxOHiQhFYEyV8Y%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnextcloud%2Fandroid%2Fissues%2F1901%23issuecomment-355724440&data=02%7C01%7C%7C00746e822b0b4905f0c808d554c5961d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508129957260471&sdata=zJaN7HOcK%2BaBE%2FN7voVV7xoD00ddwe%2FqHAldTT1Cr3k%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXb4Q_qsIt5h2euRsV29TBw931aUvmVNks5tHwNAgaJpZM4RQZ3B&data=02%7C01%7C%7C00746e822b0b4905f0c808d554c5961d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508129957260471&sdata=ian7IxF2caYzJa4EIgI8e%2BZTFZFvCWE16OUVa9VOXl8%3D&reserved=0>.

[mario]

Actually, I'm the one who helped the iOS team with Photos tab (and search in general). iOS and the Android are different platforms, starting off a different maturity codebase.

The idea outlined by @rullzer is a good one, and we'll use that. This particular thing + recyclerview will speed up quite a lot of things.

Well thank you for all your hard work! 🙂 yes, I also agree that it’s a good idea.

…

Sent from my iPhone 7 Plus On Jan 6, 2018, at 1:46 AM, Mario Đanić <notifications@github.com<mailto:notifications@github.com>> wrote: Actually, I'm the one who helped the iOS team with Photos tab (and search in general). iOS and the Android are different platforms, starting off a different maturity codebas@rullzer<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frullzer&data=02%7C01%7C%7C7dbab1aa36fa422c18b608d554d9995c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508215910727061&sdata=Bh6prnp0upFO32vTQHdQhtZg6mJvu5PUMl7ltYnFxz4%3D&reserved=0>e. The idea outlined by @rullzer<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frullzer&data=02%7C01%7C%7C7dbab1aa36fa422c18b608d554d9995c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508215910727061&sdata=Bh6prnp0upFO32vTQHdQhtZg6mJvu5PUMl7ltYnFxz4%3D&reserved=0> is a good one, and we'll use that. This particular thing + recyclerview will speed up quite a lot of things. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnextcloud%2Fandroid%2Fissues%2F1901%23issuecomment-355730373&data=02%7C01%7C%7C7dbab1aa36fa422c18b608d554d9995c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508215910727061&sdata=oPl7uODve742C8capVVKTm4u3vtZCl%2F1w5T%2BUvN6X3I%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXb4Q1YvORhhZQwuHoyVw7Rs_Eo5Y9miks5tHyTTgaJpZM4RQZ3B&data=02%7C01%7C%7C7dbab1aa36fa422c18b608d554d9995c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636508215910727061&sdata=3FakKXCBbj%2FxpsJuOuSoVV8ruLXetQ6NyunchP9sYnE%3D&reserved=0>.

[tobiasKaminsky]

@mario @AndyScherzinger
I implemented this now for photo search:

• it first loads 3 x screen, e.g. 3 x 5 rows x 4 columns = 60 items
• when reaching the bottom, it loads the next 60 items

This is possible as photo view is sorted by time and on next items I can limit the search and find only items that are older than the last timestamp.
My idea was to use the dynamic fetching also for our other search implementations, but this might be trickier for "pagination":

• sort by size would work
• sort by time: see above
• sort by name: there is afaik no way for comparing the file name --> this would be needed for a "regular" file search.

[rullzer]

Sort by name is kind of weird also I would have no idea how the query to search for the rest files would look like

Sort by time probably makes sense... Most recent first (or least recent).

[AndyScherzinger]

Fine by me @tobiasKaminsky simply because the only truly working solution is block-reading because time doesn't work. If I went on vacation "a day" can mean hundred of pictures taken with 2 phones and one DSLM. So always retrieving n elements seems to be the way to go.