Add product name to rich documents#291
Merged
AndyScherzinger merged 1 commit intomasterfrom May 9, 2019
Merged
Conversation
AndyScherzinger
previously approved these changes
May 8, 2019
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
richDocumentsProductName
branch
from
083abb6 to
2149b2d
Compare
Collaborator
Lint
FindBugs (new)
FindBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
=========================================
- Coverage 16.92% 16.9% -0.02%
=========================================
Files 120 120
Lines 5224 5229 +5
Branches 719 720 +1
=========================================
Hits 884 884
- Misses 4213 4218 +5
Partials 127 127
|
Member
Author
|
@AndyScherzinger I cannot see your review comment, do you recall what it was? |
AndyScherzinger
approved these changes
May 9, 2019
Member
|
Unfortunately,no. :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me