apply ACL groupfolders

[ArtificialOwl]

Beware, spooky review required 🎃

when running with activity_use_cached_mountpoints on a file:

• get all users [1] that have basic groupfolders' access
• get rules related to path to said file
• get list of users that might be affected by said rules
• verify access to those users
• remove users without read permission on said file from [1]

[icewind1991]

I'm not a fan of having additional explicit cross-app dependencies.

We can maybe add an storage extention interface to core that has a filterUserAccess or something similar to decouple things, but that can be done later.

Overall the approach of the filtering is fine and shouldn't be to bad for performance, once the listed issues are addressed this is good from my pov

[PVince81]

not a fan of cross-app either.
still, for backportability let's stick with this solution for now

once merged and backported we can look into make it cleaner if low effort

[ArtificialOwl]

• fixed the 2nd location for Constants::PERMISSION_READ
• squashed
• rebased

[PVince81]

👍

[PVince81]

/backport to stable25

[fschrempf]

We can maybe add an storage extention interface to core that has a filterUserAccess or something similar to decouple things, but that can be done later.

once merged and backported we can look into make it cleaner if low effort

This is a real problem and it's one example for why NC code probably gets harder and harder to maintain. You are adding technical debt and "can be done later" and "make it cleaner if low effort" effectively means that it will never be done unless there's really someone who tracks these issues.