add debug output and missing exception handlers to fix #459

[madmas]

add debug outout and exception handling fix to get rid of over-and-over sent notifications.

I think esp. the changes to line 410 helped to fix the issue.

[kesselb]

How does logException fixes something? Mind to share $e->getMessage() to see why sending the email failed?

[madmas]

Hi @kesselb , sorry, I switched the lines, I think the actual fix is below, in line 415. 410 of course only helps in regard of debugging ;-)

[kesselb]

Mind to share the exception? Also you overwrite the actual exception message. That makes it harder to debug.

[kesselb]

I'm not convinced. Right now the error handling code fails and the original exception message is replaced with a generic error message.

[kesselb]

Log the exception with $this->logger->logException($e); and log a additional warning $this->logger->warning('Failed to send notification email for user {user}', ['user' => $userName]);. You cannot use $user because it's a IUser object. Ah that might work as the normalizer will format it. I would still prefer the $userName ;)

[madmas]

I'm not convinced. Right now the error handling code fails and the original exception message is replaced with a generic error message.

My experience was vice versa - with the output I added with shown here, I got much more details.
I cannot share the exception as after implementing this, I don't see them happen on my system anymore....

[kesselb]

We still don't know why sending the notification failed in the first place. This is fixing symptoms not problems 😟