fix(notification): Deduplicate the settings check#2041
Merged
nickvergessen merged 1 commit intomasterfrom May 30, 2025
Merged
Conversation
This also fixes a problem with the files app that has a wrong setting type at this place otherwise as the type is overwritten after checking the settings. Signed-off-by: Joas Schilling <coding@schilljs.com>
Activity
|
||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
bugfix/noid/deduplicate-notification-settings-check
|
| Run status |
|
| Run duration | 02m 18s |
| Commit |
|
| Committer | Joas Schilling |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
9
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 1 failed test • Run E2E
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has comment activity |
Test Replay
Screenshots
|
|
miaulalala
approved these changes
May 28, 2025
Member
Author
|
@maintainers please check how far this needs backporting |
miaulalala
approved these changes
May 30, 2025
nickvergessen
deleted the
bugfix/noid/deduplicate-notification-settings-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a problem with the files app that has a wrong setting type at this place otherwise as the type is overwritten after checking the settings.