Skip to content

Comments

chore(NcEllipsisedOption): add docs#5663

Merged
ShGKme merged 1 commit intomasterfrom
docs/NcEllipsisedOption
Jun 4, 2024
Merged

chore(NcEllipsisedOption): add docs#5663
ShGKme merged 1 commit intomasterfrom
docs/NcEllipsisedOption

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 4, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@ShGKme ShGKme added feature: documentation Related to the documentation feature: select Related to the NcSelect* components feature: ellipsised-option labels Jun 4, 2024
@ShGKme ShGKme requested review from Pytal and susnux June 4, 2024 13:44
@ShGKme ShGKme self-assigned this Jun 4, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

/backport to next

```vue
<template>
<div>
<h5>Plain text</h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be h4 no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks too huge to me 👀

But can replace it with h4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or with separated examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it

Copy link
Contributor Author

@ShGKme ShGKme Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, screenshot updated

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the docs/NcEllipsisedOption branch from 3ee528e to e3699d5 Compare June 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: documentation Related to the documentation feature: ellipsised-option feature: select Related to the NcSelect* components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants