Remove outdated documentation from command-file-setup.mdx#33
Merged
notunderctrl merged 4 commits intoneplextech:masterfrom Dec 12, 2023
xcfio:fix
Merged
Remove outdated documentation from command-file-setup.mdx#33notunderctrl merged 4 commits intoneplextech:masterfrom xcfio:fix
notunderctrl merged 4 commits intoneplextech:masterfrom
xcfio:fix
Conversation
✅ Deploy Preview for commandkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
notunderctrl
requested changes
Dec 7, 2023
Collaborator
notunderctrl
left a comment
notunderctrl
left a comment
There was a problem hiding this comment.
The if statement in this case is redundant really. Based on the structure of the command data, interaction.targetMessage will always have a value. I think it would be a cleaner representation without the if statement.
Contributor
Author
Yeah. But TypeScript gives warning if I don't use it |
notunderctrl
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove outdated documentation from command-file-setup.mdx