Fix for ButtonKit & Signals Docs#23
Merged
notunderctrl merged 2 commits intoneplextech:masterfrom Nov 12, 2023
e60m5ss:docs-changes
Merged
Fix for ButtonKit & Signals Docs#23notunderctrl merged 2 commits intoneplextech:masterfrom e60m5ss:docs-changes
notunderctrl merged 2 commits intoneplextech:masterfrom
e60m5ss:docs-changes
Conversation
✅ Deploy Preview for commandkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
notunderctrl
requested changes
Nov 9, 2023
twlite
requested changes
Nov 9, 2023
Contributor
Author
Okay, I'll rename them. |
Contributor
Author
|
@notunderctrl I've renamed the variables to use the better names you've suggested. A review would be appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed two files.