Fix: Multiline Text though clipped can be scrolled into view#2584
Closed
tienifr wants to merge 1 commit intonecolas:masterfrom
Closed
Fix: Multiline Text though clipped can be scrolled into view#2584tienifr wants to merge 1 commit intonecolas:masterfrom
Text though clipped can be scrolled into view#2584tienifr wants to merge 1 commit intonecolas:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9224e34:
|
|
@necolas could you please take a look at this or get someone to review it for us please? |
|
Released under the new fork https://github.com/quantizor/react-native-web-fork/releases/tag/v0.20.2 |
necolas
pushed a commit
that referenced
this pull request
Apr 3, 2025
necolas
pushed a commit
that referenced
this pull request
Apr 3, 2025
|
I'm having an issue with this fix on older chromium versions - seem's like overflow:clip is not supported on chromium versions <89 A lot of Tizen/LG WebOS web engine powered TV's are running old chromium versions (even tv's from like 2020-2022). Any way to conditionally apply this change only to webengines that support that ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes #2582.
On mobile Web, multiline
Text's clipped part can be scrolled into view by dragging selection cursor. This PR blocks scrolling entirely, through any mechanism, over overflown text.Tests
TextwithnumberOfLines > 1Screenshots/Videos
Screenrecording_20230925_183054.mp4