ResponderTouchHistoryStore into instanciated class#2190
Closed
zarubond wants to merge 1 commit intonecolas:masterfrom
zarubond:zarubond/responder_instance
Closed
ResponderTouchHistoryStore into instanciated class#2190zarubond wants to merge 1 commit intonecolas:masterfrom zarubond:zarubond/responder_instance
zarubond wants to merge 1 commit intonecolas:masterfrom
zarubond:zarubond/responder_instance
Conversation
Contributor
Author
Owner
|
Yes I'm interested in supporting multiple windows/iframes. Thanks, this PR looks OK in principle. I'm currently focused on other updates and will have to come back to this later though |
Owner
|
Thanks, this is now in master. |
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
Refactor ResponderTouchHistoryStore from singleton to class instantiated in ResponderSystem. This is a part of greater effort to enable support for multiple browser windows Close necolas#2190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ResponderTouchHistoryStore from singleton to class instantiated in ResponderSystem. The eventual the plan is to have multi-window support in RNW which requires having an instance of this Store for each window. PR code does change the internal logic.
This PR is a part of greater effort to enable support for multiple browser windows in RNW. Whole change is available in the draft PR #2185 .