Adjust AppState to match 0.65 API#2129
Closed
netshade wants to merge 5 commits intonecolas:masterfrom
Closed
Conversation
…ate listener was actually desired
…from removeEventListener
|
But it's a breaking changes for react-native older than 0.65.* |
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 0.65,
AppStatehas been changed to emit anEmitterSubscriptionwhen calling.add; this is in line w/ the expectation that you should no longer callremoveEventListeneronAppState, but instead call.removeon the returned subscription. This PR changesAppStatesuch that it uses the internal_EventEmitterobject to mirror how 0.65+AppStateshould behave, and allow callers to unsubscribe from the emitter using the.removemethod.In doing so, this changes the implementation such that
documentshould only ever have one and only one event listener to app viability changes; that event listener does the work of dispatching to the internalEventEmitterobject, which dispatches to any N application level event listeners that are waiting forAppStatechanges.Thanks for any review / criticism, not sure if that implementation change is the right one or captured what changed correctly. Also feel slightly sketchy with regards to what I did in the tests, so happy for any opinion there.