Use multiline ellipsis implementation for single line too#2113
Closed
janicduplessis wants to merge 1 commit intonecolas:masterfrom
Closed
Use multiline ellipsis implementation for single line too#2113janicduplessis wants to merge 1 commit intonecolas:masterfrom
janicduplessis wants to merge 1 commit intonecolas:masterfrom
Conversation
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
Safari requires use of `white-space:nowrap` if not using the multi-line technique. This patch uses the multi-lines styles to truncate single-lines. Fix necolas#2111 Close necolas#2113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use multiline
numberOfLinesimplementation in all cases, see #2111 for more details.Fixes #2111