Merged
Conversation
Contributor
|
I get the double help bug with the following code $cmd = new Commando\Command();
$cmd->option('p')
->require()
->aka('package')
->describedAs('The name of the package dir');
$cmd->option('c')
->require()
->aka('class')
->describedAs('The full namespaced class name of the model, will be added to -namespace if set');
$cmd->option('ns')
->aka('namespace')
->describedAs('The namespace of the package module');This pull request fixes that why hasn't this been merged? |
Contributor
Author
|
are you there, @nategood ? |
Contributor
|
It is so frustrating when this happens. This is a nice package but has a small bug. |
Owner
|
Sorry guys. Had a bit of a health scare recently that has set me behind on my inbox. I'll review and merge. |
Contributor
Author
|
@nategood no worries, man! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assures the
parsemethod is called only once.When the script is short-circuited on default help, it exists without mark the command as parsed, showing the helo message twice.
All tests passed.