Keep iotune section in the VM's XML after live migration (#3171) #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keep iotune section in the VM's XML after live migration When live migrating a KVM VM among local storages, the VM loses the <iotune> section on its XML, therefore, having no IO limitations. This commit removes the piece of code that deletes the <iotune> section in the XML. * Add test for replaceStorage in LibvirtMigrateCommandWrapper Signed-off-by: Wido den Hollander <[email protected]> * Fix Javadoc for method replaceIpForVNCInDescFile
nathanejohnson
pushed a commit
that referenced
this pull request
Jan 28, 2021
… fixes (apache#59) Add actions from old UI to new UI Fixes: #40 Doing the following: Extract out actions from old UI to new for infra section - zones, pods, clusters, ...etc. Support translation of labels for actions instead of hard coding them Translation of action buttons in list view, detail view, forms and also their fields will now be human readable. Some misc changes - like comparing API param names with case insensitive stuff, allowing reusing of same API for multiple actions by passing defaultArgs: to action in config files. Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When live migrating a KVM VM among local storages, the VM loses the
section on its XML, therefore, having no IO limitations.
This commit removes the piece of code that deletes the section
in the XML.
Signed-off-by: Wido den Hollander [email protected]
Description
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?