Conversation
|
✔️ Deploy Preview for next-multinet-client ready! 🔨 Explore the source changes: 39882a8 🔍 Inspect the deploy log: https://app.netlify.com/sites/next-multinet-client/deploys/61b91dd5be68a00008b41335 😎 Browse the preview: https://deploy-preview-210--next-multinet-client.netlify.app |
jjnesbitt
requested changes
Dec 13, 2021
Member
jjnesbitt
left a comment
jjnesbitt
left a comment
There was a problem hiding this comment.
Looks good overall, just a few suggestions
src/views/WorkspaceDetail.vue
Outdated
Comment on lines
+182
to
+183
| setup(props) { | ||
| // const router = useRouter(); |
Member
There was a problem hiding this comment.
This is how I use the router with CompositionAPI on Vue2
Suggested change
| setup(props) { | |
| // const router = useRouter(); | |
| setup(props, ctx) { | |
| const router = ctx.root.$router; |
src/views/WorkspaceDetail.vue
Outdated
Comment on lines
+149
to
+152
|
|
||
| // import { useRouter } from 'vue-router'; // Router import vue3 syntax | ||
| // eslint-disable-next-line import/no-cycle | ||
| import router from '@/router'; // Temporary router syntax that lets us use the old push |
Member
There was a problem hiding this comment.
Suggested change
| // import { useRouter } from 'vue-router'; // Router import vue3 syntax | |
| // eslint-disable-next-line import/no-cycle | |
| import router from '@/router'; // Temporary router syntax that lets us use the old push |
If my suggestion around setup is committed, this is no longer needed.
src/views/WorkspaceDetail.vue
Outdated
Comment on lines
+250
to
+251
| // eslint-disable-next-line no-return-assign | ||
| watch(localWorkspace, () => requestError.value = null); |
Member
There was a problem hiding this comment.
Rather than ignore the rule, I'd just follow it here
Suggested change
| // eslint-disable-next-line no-return-assign | |
| watch(localWorkspace, () => requestError.value = null); | |
| watch(localWorkspace, () => { requestError.value = null; }); |
Member
Author
|
Thanks for the suggestions, @AlmightyYakob. That clears up the code quite a bit |
jjnesbitt
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #174
Give a longer description of what this PR addresses and why it's needed
This PR does 3 things:
Provide pictures/videos of the behavior before and after these changes (optional)
With upload in progress:
Without upload in progress (same as before):
Are there any additional TODOs before this PR is ready to go?
TODOs: