Conversation
|
✔️ Deploy Preview for next-multinet-client ready! 🔨 Explore the source changes: e3a1b89 🔍 Inspect the deploy log: https://app.netlify.com/sites/next-multinet-client/deploys/61953b26d173260007bcb5a6 😎 Browse the preview: https://deploy-preview-204--next-multinet-client.netlify.app/ |
waxlamp
left a comment
waxlamp
left a comment
There was a problem hiding this comment.
Looks like a slew of useful improvements, thanks for doing this @JackWilb. I just had a few questions and one request for removing a console.log, but I'm marking this as approved so you can merge without a second round of reviews.
| tables(state: State, getters): string[] { | ||
| if (state.currentWorkspace !== null && state.currentWorkspace.nodeTables && state.currentWorkspace.edgeTables) { | ||
| return getters.nodeTables.concat(getters.edgeTables).sort(); | ||
| } | ||
| return []; |
There was a problem hiding this comment.
What problem does it solve to alphabetize all the tables? There's an argument that the tables should appear in order of newness (though I'm not sure that's what happens currently), but alphabetic is a fine default choice too.
More generally, we ought to be able to change the sort order on the fly. Would you mind filing an issue to that effect?
There was a problem hiding this comment.
I was still curious why you wanted to see tables alphabetized.
2 participants
As I've been using the app I've noticed many small UX issues that make the app harder to use. This is a first attempt at addressing some of the more heinous ones: