Require that Sessions.state is a python dict, not string#161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
No
Give a longer description of what this PR addresses and why it's needed
With our prior implementation, the state could be saved as any type, including string. Since the trrack library was exporting as string, this meant that saved state were of type string. We added a couple new functions to the trrack library to allow for importing and exporting the actual object, and they work seamlessly with these changes. There will be PRs in all vis apps to align with this change and get to a more consistent database state.
Provide pictures/videos of the behavior before and after these changes (optional)
N/A
Are there any additional TODOs before this PR is ready to go?
No