Skip to content

Use shared login function from multinet library#347

Merged
JackWilb merged 3 commits intomainfrom
shared-login-library
Mar 13, 2023
Merged

Use shared login function from multinet library#347
JackWilb merged 3 commits intomainfrom
shared-login-library

Conversation

@waxlamp
Copy link
Copy Markdown
Contributor

@waxlamp waxlamp commented Feb 1, 2023

This PR changes the use of private functions to those from multinet-app/multinetjs#77.

Marking this as draft because once multinetjs is released, this branch will need to update the dependent multinetjs version before it can be reviewed and merged.

Note that the calling sequence has changed to make use of the library
function easier. The function now returns the cookie value rather than
the entire cookie string (i.e., "bar" instead of "foo=bar").
@waxlamp waxlamp requested a review from JackWilb February 1, 2023 19:50
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 1, 2023

Deploy Preview for next-multilink ready!

Name Link
🔨 Latest commit 239dfab
🔍 Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/640f512a2fedff0008dac012
😎 Deploy Preview https://deploy-preview-347--next-multilink.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JackWilb
JackWilb previously approved these changes Mar 13, 2023
@JackWilb JackWilb marked this pull request as ready for review March 13, 2023 16:35
@JackWilb JackWilb merged commit fcfd4c7 into main Mar 13, 2023
@JackWilb JackWilb deleted the shared-login-library branch March 13, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants