Conversation
There was a problem hiding this comment.
Pull request overview
This PR raises the minimum deployment target versions for macOS, iOS, and tvOS platforms to 11.0, 14.0, and 14.0 respectively (from 10.15, 13.0, and 13.0). The changes include updating dependency library versions and modifying build configurations to support these new minimum targets.
- Updated platform minimum versions in Package.swift and build scripts
- Updated multiple dependency library versions to newer releases
- Simplified FFmpeg VideoToolbox compatibility patching by replacing OpenGL references with Metal
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/Package.template.swift | Updated platform minimum versions to macOS 11.0, iOS 14.0, tvOS 14.0 |
| Sources/BuildScripts/patch/libmpv/0003-fix-ffmpeg-n8.0.patch | Removed patch file (no longer needed) |
| Sources/BuildScripts/patch/libmpv/0002-revert-build-static.patch | Updated patch context for Swift build configuration |
| Sources/BuildScripts/XCFrameworkBuild/main.swift | Updated dependency versions and simplified VideoToolbox compatibility logic |
| Sources/BuildScripts/XCFrameworkBuild/base.swift | Updated minimum version constants for iOS and tvOS platforms |
| Package.swift | Updated platform requirements and all binary dependency URLs/checksums to version 0.41.0-alpha |
| .github/workflows/ci.yml | Added branch filter to only run CI on develop branch |
Comments suppressed due to low confidence (1)
Sources/BuildScripts/patch/libmpv/0003-fix-ffmpeg-n8.0.patch:1
- The patch shows a commit date of 'Fri, 28 Mar 2025' which is in the future. This date should be corrected to reflect an actual past date when this patch was created.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case .tvos, .tvsimulator: | ||
| return "13.0" | ||
| return "14.0" | ||
| case .macos: |
There was a problem hiding this comment.
The macOS minimum version remains unchanged at 11.0, but the PR title and changes indicate this is part of the minimum version increase. Consider adding a comment explaining that macOS 11.0 was already the minimum and is being kept, to clarify this isn't an oversight.
| case .macos: | |
| case .macos: | |
| // macOS 11.0 was already the minimum supported version before this update and is intentionally kept unchanged. |
1 participant
No description provided.