Skip to content
This repository was archived by the owner on Mar 28, 2019. It is now read-only.

Conversation

@flukeout
Copy link

We need access to the token for displaying information to the user about their error, but not all of the errors were passing it. This changes that.

@Pomax - does this look sane? Still WIP

@Pomax
Copy link
Contributor

Pomax commented Sep 27, 2017

It looks sane, but I would change the order of arguments so that you can rely on the fact that argument 1 is always the error name, and argument 2 is always the token, regardless of whatever other arguments are passed that are not shared by all errors (not all errors ask for this, for instance, so that would change the position of token, sometimes being arguments[1], sometimes arguments[2], you want that to be stable)

@flukeout flukeout changed the title [WIP] Adding token to all errors. Slowparse Updates Dec 7, 2017
@flukeout flukeout changed the title Slowparse Updates [WIP] Slowparse Updates Dec 7, 2017
@Pomax Pomax self-requested a review January 18, 2018 18:48
@Pomax
Copy link
Contributor

Pomax commented Jan 18, 2018

@flukeout what do we want to do with this PR?

@Pomax Pomax removed their request for review March 6, 2018 00:24
@Pomax
Copy link
Contributor

Pomax commented Mar 6, 2018

closing, unfortunately.

@Pomax Pomax closed this Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants