Add support for portable-atomic for targets with no CAS#37
Merged
bholley merged 2 commits intomozilla:masterfrom Apr 20, 2026
Merged
Add support for portable-atomic for targets with no CAS#37bholley merged 2 commits intomozilla:masterfrom
bholley merged 2 commits intomozilla:masterfrom
Conversation
peku33
changed the title
Collaborator
|
Thanks! I merged the lint PR, can you rebase this one? Edit: Nevermind, Looks like GH can do this now. |
Collaborator
|
Published this as 0.1.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 of 2 pull request for adding portable-atomic support to atomic_refcell. I will rebase it if the lint PR gets merged.
This is the actual implementation, with roughly 10 lines of actual changes.
This adds optional portable-atomic support, so atomic refcell can work on targets without CAS.
I've verified it didn't build in my project before the change and now it does.