Skip to content

make it respond#188

Merged
lmorchard merged 1 commit intomasterfrom
make-it-respond
Mar 21, 2018
Merged

make it respond#188
lmorchard merged 1 commit intomasterfrom
make-it-respond

Conversation

@johngruen
Copy link
Contributor

@johngruen johngruen commented Mar 21, 2018

Fixes #41

@@ -0,0 +1,44 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add: "title": "006",

"tab_line": {
"h": 360,
"s": 100,
"l": 60
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to tweak the /docs/theme-schema.json file as well. Along with all the other hsl[a] definitions, add the following new property:

                "tab_line": {
                    "type": "object",
                    "properties": {
                        "h": {
                            "type": "integer",
                            "maximum": 360,
                            "minimum": 0
                        },
                        "s": {
                            "type": "integer",
                            "maximum": 100,
                            "minimum": 0
                        },
                        "l": {
                            "type": "integer",
                            "maximum": 100,
                            "minimum": 0
                        }
                    },
                    "required": ["h", "s", "l"],
                    "additionalProperties": false
                }

It's a bit of a funny one, since we've only added a tab_line definition to 2 of the 8 themes, so it isn't a required property unless we backfill it in to the other themes. But this should be enough to pass the super awesome theme linter.

@johngruen
Copy link
Contributor Author

Oh yeah, i didn't see the new linter stuff after i rebased. looks awesome. I added tab_lines to all the current present themes (which are all going to change anyway)

@pdehaan
Copy link
Contributor

pdehaan commented Mar 21, 2018

There is some cropping of the color pickers at 640 where the panel floats slightly off screen. Not sure if that is fixable, or even worth fixing. Stuff doesn't start breaking until around 620px wide, where the "B" text input disappears off the right edge.

themer640

Similar stuff happens (to lesser degree) for the "Toolbar Icons and Text" color picker on the left side of the UI, were the "Hex" text input and color chips float slightly off the edge, but is still usable:

firefox_themer_640b

Probably the most problematic is the Theme Texture picker, since it causes some horizontal scrollage.

firefox_themer_theme_texture

firefox_themer_-dual_scrollage


UPDATE: Filed as #199

@johngruen
Copy link
Contributor Author

@pdehaan yeah...maybe follow up bugs?

Copy link
Contributor

@lmorchard lmorchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll say let's merge this and continue to iterate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants