Conversation
910ffae to
28cb115
Compare
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "tab_line": { | ||
| "h": 360, | ||
| "s": 100, | ||
| "l": 60 |
There was a problem hiding this comment.
You'll need to tweak the /docs/theme-schema.json file as well. Along with all the other hsl[a] definitions, add the following new property:
"tab_line": {
"type": "object",
"properties": {
"h": {
"type": "integer",
"maximum": 360,
"minimum": 0
},
"s": {
"type": "integer",
"maximum": 100,
"minimum": 0
},
"l": {
"type": "integer",
"maximum": 100,
"minimum": 0
}
},
"required": ["h", "s", "l"],
"additionalProperties": false
}It's a bit of a funny one, since we've only added a tab_line definition to 2 of the 8 themes, so it isn't a required property unless we backfill it in to the other themes. But this should be enough to pass the super awesome theme linter.
28cb115 to
bdc30bc
Compare
|
Oh yeah, i didn't see the new linter stuff after i rebased. looks awesome. I added tab_lines to all the current present themes (which are all going to change anyway) |
|
There is some cropping of the color pickers at 640 where the panel floats slightly off screen. Not sure if that is fixable, or even worth fixing. Stuff doesn't start breaking until around 620px wide, where the "B" text input disappears off the right edge. Similar stuff happens (to lesser degree) for the "Toolbar Icons and Text" color picker on the left side of the UI, were the "Hex" text input and color chips float slightly off the edge, but is still usable: Probably the most problematic is the Theme Texture picker, since it causes some horizontal scrollage. UPDATE: Filed as #199 |
|
@pdehaan yeah...maybe follow up bugs? |
lmorchard
left a comment
There was a problem hiding this comment.
Yeah, I'll say let's merge this and continue to iterate




Fixes #41