Populate opengraph/twitter meta tags from package.json#180
Populate opengraph/twitter meta tags from package.json#180lmorchard merged 1 commit intomozilla:masterfrom
Conversation
| <meta property="og:type" content="website" /> | ||
| <!-- Twitter card meta tags--> | ||
| <meta name="twitter:card" content="themer" /> | ||
| <meta name="twitter:card" content="summary" /> |
There was a problem hiding this comment.
Not sure "themer" is a valid card type here. I stole "summary" from the TestPilot site's <meta> tags.
| <meta name="twitter:title" content="Grab your parachute and get access to experimental Firefox features." /> | ||
| <meta name="twitter:description" content="Theming demo for Firefox Quantum and beyond." /> | ||
| <title>Firefox Themer</title> | ||
| <meta name="twitter:title" content="<%= htmlWebpackPlugin.options.title %>" /> |
There was a problem hiding this comment.
I'll have to re-read the docs to try and understand the difference betwixt a twitter:title and twitter:description, but tweak will change the twitter:title to "Firefox Themer" (versus the current parachute reference, which may have been a TestPilot relic).
| chunks: ["index"], | ||
| title: pkg.title, | ||
| description: pkg.description, | ||
| homepage: pkg.homepage |
There was a problem hiding this comment.
Conversely, I could just shim all of package.json values into the options (a la pkg: pkg), but that felt a wee bit heavy handed, so I just injected the 3 params I "cared" about.
chuckharmston
left a comment
chuckharmston
left a comment
There was a problem hiding this comment.
Not 100% sure of our l10n plans, so I won't merge it, but this works great and the code looks good.
|
This is all I know about l10n. I should probably file a separate bug about l10n status so we can discuss there, and put it in a milestone (if we're doing it for v1 or waiting)... UPDATE: Submitted #182 to discuss potential localization plans. |
|
No localization plans yet, wanted to get to feature complete since things were kind of in experimental flux and strings would have been anything but stable |
3 participants
No doubt this will be useless when we add l10n, but until then... 🎉