feat: rebuild PR action task definitions correctly in CoT verification code#730
Merged
bhearsum merged 1 commit intomozilla-releng:mainfrom Nov 28, 2025
Merged
Conversation
510765d to
bc41751
Compare
Contributor
Author
|
I was able to reproduce the problems I saw in production with |
bc41751 to
d26bdce
Compare
…n code
Without this we end up with differences in metadata, tags, routes, scopes, and sometimes the env, eg:
```
["[('change',\n"
" 'metadata.owner',\n"
" ('action@noreply.mozilla.org', 'pr-action@noreply.mozilla.org')),\n"
" ('change', 'metadata.name', ('Action: Train', 'PR action: Train')),\n"
" ('change',\n"
" 'metadata.description',\n"
" ('Initiate part or all of the training pipeline\\n'\n"
" '\\n'\n"
" 'Action triggered by clientID '\n"
" '`mozilla-auth0/ad|Mozilla-LDAP|bhearsum/cli-KDQzKW`\\n',\n"
" 'Initiate part or all of the training pipeline\\n'\n"
" 'PR action triggered by clientID '\n"
" '`mozilla-auth0/ad|Mozilla-LDAP|bhearsum/cli-KDQzKW`\\n')),\n"
" ('change',\n"
" 'tags.createdForUser',\n"
" ('action@noreply.mozilla.org', 'pr-action@noreply.mozilla.org')),\n"
" ('remove',\n"
" 'routes',\n"
' [(2,\n'
' '
"'index.translations.v2.translations.revision.436b91ba4ef7f5aaf7c619a9218c3c9ea0fa63d9.taskgraph.actions.Ilsl2Xq4SNivSjs4WQOEBg')]),\n"
" ('change',\n"
" ['scopes', 0],\n"
" ('assume:repo:github.com/bhearsum/translations:action:train',\n"
" 'assume:repo:github.com/mozilla/translations:pr-action:train')),\n"
" ('change',\n"
" 'payload.env.TRANSLATIONS_BASE_REPOSITORY',\n"
" ('https://github.com/bhearsum/translations',\n"
" 'https://github.com/mozilla/translations')),\n"
" ('change', 'payload.env.TRANSLATIONS_BASE_REF', ('push-plrwuypxlpum', "
"'main')),\n"
" ('change', 'extra.tasks_for', ('action', 'pr-action'))]"]
```
d26bdce to
832c340
Compare
jcristau
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this we end up with differences in metadata, tags, routes, scopes, and sometimes the env, eg: