Allow use of docker container for npm install #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #168
This PR does a couple of things:
packageordeploycommand. This image will then be used as the environment in whichnpm installwill be run. An example of the type of image you'd want to use is https://github.com/lambci/docker-lambda .There is also an assumption made that the image matches the lambda environment, such as mounting the code directory to and setting the working directory to
/var/task.$PWD/.lambda. On a mac,os.tmpDir()resolves to a symlink, which are notoriously difficult to work with when mounting volumes inside a docker container. Changing the code directory seemed like a simple approach to alleviate those concerns, though I realize this is a somewhat inconvenient change.Example usage: