Bugfix InvalidParameterValueException is given when createFunction #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In updateFunctionConfiguration, we set empty characters so that setting can be erased, but failed when createFunction.
DeviaVir
requested changes
Mar 29, 2017
| // Set default value to null. | ||
| // Because createFunction fails if it is empty character. | ||
| TargetArn: null | ||
| } |
Collaborator
There was a problem hiding this comment.
It might make more sense to leave it out completely and only add it when passed through to us? This might also solve for your TODO.
Contributor
Author
There was a problem hiding this comment.
I tried implementing undefined check, but how about it?
Collaborator
There was a problem hiding this comment.
@abetomo are you sure this solves for implicitly unsetting the DLQ?
Contributor
Author
There was a problem hiding this comment.
@DeviaVir
By writing AWS_DLQ_TARGET_ARN= in .env, empty characters will pass and you can cancel the setting.
Use an empty string as a value
Make it undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updateFunctionConfiguration, we set empty characters so that setting
can be erased, but failed when createFunction.