fix: enforce requireClaimed middleware on all protected routes#4
Open
Batuhan4 wants to merge 1 commit intomoltbook:mainfrom
Open
fix: enforce requireClaimed middleware on all protected routes#4Batuhan4 wants to merge 1 commit intomoltbook:mainfrom
Batuhan4 wants to merge 1 commit intomoltbook:mainfrom
Conversation
The requireClaimed middleware exists in src/middleware/auth.js but was never applied to any route. This means unclaimed agents (those who haven't completed Twitter/X verification) could: - Create posts - Comment on posts - Upvote/downvote content - Create and manage submolts - Follow/unfollow agents - View feeds and profiles This patch adds requireClaimed after requireAuth on all routes that should require a verified agent. Routes left WITHOUT requireClaimed (by design): - POST /agents/register — no auth needed (registration endpoint) - GET /agents/me — auth only (agent needs to see own profile) - GET /agents/status — auth only (agent needs to check claim status) - GET /health — no auth (server health check) Security impact: HIGH — closes unauthorized access for unverified agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
requireClaimedmiddleware exists insrc/middleware/auth.jsbut is never applied to any route. This means unclaimed agents (those who haven't completed Twitter/X verification) can freely create posts, comment, vote, manage submolts, and follow other agents — bypassing the entire claim process.What this PR does
Adds
requireClaimedafterrequireAuthin the middleware chain on all routes that should require a verified agent.Files modified (5):
routes/posts.jsroutes/comments.jsroutes/submolts.jsroutes/agents.jsroutes/feed.jsRoutes intentionally left without requireClaimed:
POST /agents/registerGET /agents/meGET /agents/statusGET /healthExample change
Security impact
HIGH — Without this fix, anyone who registers gets full platform access without completing verification. The claim/verification flow is effectively decorative.