Open
Conversation
…ontrols (e.g., TextArea, TextInput). - Improve checkbox and radio list rendering: - Refactor inline check classes and layout logic. - Add support for specifying items per row. - Extend button customization: - Introduce `getFormButtonClass()` for unified button styling. - Add rounded styling utilities (via `Helper\ButtonRounded`). - Ensure consistency in `assert()` usage by adopting global function. - Enhance CSS for better input alignment, floating labels, and button styles. - Refactor test layouts to align with new rendering logic. - Add new unit tests for quick copy functionality and items-per-row rendering.
- Introduce `QuickCopyable` interface for streamlined button handling. - Update `TextArea` and `TextInput` to implement `QuickCopyable`. - Replace `method_exists` checks with `instanceof QuickCopyable`. - Optimize imports and simplify `Duplicator` class for cleaner codebase.
- Replace redundant recursive `getValue` call with corrected logic. - Optimize `signalReceived` by updating `assert()` and using `SignalDial` directly. - Add `controlClass` initialization for consistent styling. - Refine `setPrompt` to accept nullable values.
kravcik
reviewed
Apr 7, 2026
src/control/Button.php
Outdated
| ->name($this->getName()) | ||
| ->class('btn btn-' . $color . ($input->getAttribute('class') ? ' ' . $input->getAttribute('class') : '')) | ||
| ->addHtml($this->icon ? \Kravcik\LatteFontAwesomeIcon\Extension::render($this->icon) : '') | ||
| ->class('btn' . $this->getFormButtonClass() . ' px-4 btn-' . $color . (trim((string) $input->getAttribute('class')) !== '' ? ' ' . $input->getAttribute('class') : '')) |
Member
There was a problem hiding this comment.
vyhezčit... trim(string.. celý implode a pak trim?
kravcik
reviewed
Apr 7, 2026
src/control/SubmitButton.php
Outdated
| $button = Html::el('button') | ||
| ->name($this->getName()) | ||
| ->class('btn rounded-pill px-4 ' . $input->getAttribute('class') . ' btn-' . $color) | ||
| ->class('btn' . $this->getFormButtonClass() . ' px-4' . (trim((string) $input->getAttribute('class')) !== '' ? ' ' . $input->getAttribute('class') : '') . ' btn-' . $color) |
kravcik
requested changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.