Conversation
dsp-ant
approved these changes
Nov 19, 2024
HarleyCoops
pushed a commit
to HarleyCoops/ClaudeServers
that referenced
this pull request
Nov 28, 2024
…qlite-server Added SQLite Notes To Do Server
mounta11n
pushed a commit
to mounta11n/mcp-servers
that referenced
this pull request
Mar 9, 2025
…onfig-klmt Add Smithery config
CDRPico
pushed a commit
to CDRPico/mcp-servers
that referenced
this pull request
Mar 10, 2025
…ys-support added support for all of sentry
PazerOP
referenced
this pull request
in PazerOP/mcp-template
Jul 15, 2025
Added SQLite Notes To Do Server
noahgift
pushed a commit
to noahgift/servers
that referenced
this pull request
Aug 17, 2025
…protocol#3) Updates the requirements on [garde](https://github.com/jprochazk/garde) to permit the latest version. - [Release notes](https://github.com/jprochazk/garde/releases) - [Commits](jprochazk/garde@v0.18.0...v0.22.0) --- updated-dependencies: - dependency-name: garde dependency-version: 0.22.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
quocnam1
pushed a commit
to quocnam1/MCPServers
that referenced
this pull request
Apr 18, 2026
PR modelcontextprotocol#3921 fixes isPathWithinAllowedDirectories for UNC paths, but three other sites in the filesystem server also corrupt UNC paths via path.resolve or preserve them incorrectly through path.normalize: 1. path-validation.ts::normalizePossiblyUNCPath path.normalize preserves trailing separators on UNC paths on Windows (unlike path.resolve for drive paths), so 'normalizedDir + path.sep' produces a double separator that startsWith() never matches. Strip the trailing separator to harmonize. 2. lib.ts::validatePath Calls path.resolve(expandedPath) before the allowed-directory check, which on Windows corrupts UNC paths into drive-relative paths (\\\\server\\share -> C:\\server\\share). Skip path.resolve for UNC paths and let normalizePath handle them. 3. index.ts bootstrap Same path.resolve corruption when normalizing allowed directories at server startup, before they are stored via setAllowedDirectories. Same guard applied. All non-UNC paths retain existing behavior (path.resolve + normalize). Tests added: - 4 tests in path-validation.test.ts for the trailing-separator case - 6 tests in lib.test.ts for validatePath end-to-end on UNC, gated behind process.platform === 'win32' and using the existing fs mock pattern - Bug modelcontextprotocol#3 (bootstrap) has no direct unit test since UNC access in CI is not available, but the fix applies the same principle as validatePath and is logically covered. Fixes modelcontextprotocol#3756 Supersedes modelcontextprotocol#3921
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial version of the create-mcp-server todo notes application using SQLite as the persistent storage system. This is to demonstrate a Python MCP server that works with Claude Desktop