This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Merged
Conversation
Add arguments property
bendvc
reviewed
May 6, 2019
Contributor
bendvc
left a comment
There was a problem hiding this comment.
Hi @jkeane64
I took a look at your requested change and it looked good. Only one small change to maintain consistency with the rest of our models. If you don't mind making that change, I can work on making a release.
Thanks,
Ben
src/models/Fault.js
Outdated
| obj['type'] = ApiClient.convertToType(data['type'], 'String') | ||
| } | ||
| if (data.hasOwnProperty('arguments')) { | ||
| obj['arguments'] = ApiClient.convertToType(data['arguments'], Object) |
Contributor
There was a problem hiding this comment.
If we are going to by consistent in the way our type coercion is done in the rest of the models the correct argument to pass into convertToType should be {String: 'Blob'} or {String: Object}. I would try these to ensure they work, but looking at the code it should work no problem. Doing it this way is a little bit more descriptive on the data's property type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add arguments property
Description
Adds arguments to the Fault model as this provides valuable information specifically for Reitmans project
No access to arguments object from fault message
Type of change
Changes
Added arguments to Fault Model
How to test this PR?
Checklist:
npm run lint)README.mdandCHANGELOG.md) - N/Anpm test)