Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Add/Update Models#15

Merged
bendvc merged 3 commits intodevelopfrom
add-props
Feb 5, 2019
Merged

Add/Update Models#15
bendvc merged 3 commits intodevelopfrom
add-props

Conversation

@bendvc
Copy link
Copy Markdown
Contributor

@bendvc bendvc commented Jan 31, 2019

A partner has run into an issue where the variation attribute values doesn't have the 'image' nor 'image_swatch' properties. This PR adds the parsing of these values. As well as a few other properties.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Changes

  • Added image and image_swatch properties on the VariationAttributeValue model
  • Added represented_product and represented_products on the ProductSearchHit model
  • Created ProductRef model

How to test this PR?

You can test this PR by following the below steps:

  1. Clone and npm ci the mobify-platform-sdks project
  2. Clone this repo (particularly this branch)
  3. Link these projects by first installing and building the commercecloud-ocapi-client then running npm link
  4. In the packages/commerce-integrations folder of the sdks project run npm link ../../../commercecloud-ocapi-client
  5. Once these are linked you can run the explore project packages/explorer and previewing here
  6. Search for some products and you should now see the correct content in the models.

Checklist:

  • My code follows the style guidelines of this project (npm run lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md and CHANGELOG.md)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (npm test)

@bendvc bendvc changed the title Add/Update Modals WIP Add/Update Modals Jan 31, 2019
@kevinxh kevinxh changed the title Add/Update Modals Add/Update Models Jan 31, 2019
@bendvc bendvc merged commit f58e446 into develop Feb 5, 2019
@bendvc bendvc deleted the add-props branch February 5, 2019 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants