This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Conversation
kevinxh
reviewed
Feb 1, 2019
kevinxh
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partner has run into an issue where the variation attribute values doesn't have the 'image' nor 'image_swatch' properties. This PR adds the parsing of these values. As well as a few other properties.
Type of change
Changes
imageandimage_swatchproperties on the VariationAttributeValue modelrepresented_productandrepresented_productson the ProductSearchHit modelProductRefmodelHow to test this PR?
You can test this PR by following the below steps:
npm cithemobify-platform-sdksprojectcommercecloud-ocapi-clientthen runningnpm linkpackages/commerce-integrationsfolder of the sdks project runnpm link ../../../commercecloud-ocapi-clientpackages/explorerand previewing hereChecklist:
npm run lint)README.mdandCHANGELOG.md)npm test)