Simplify IMAP4_TLS class and fix Python 3.14+ compatibility#629
Merged
mjs merged 4 commits intomjs:masterfrom Jan 2, 2026
Merged
Simplify IMAP4_TLS class and fix Python 3.14+ compatibility#629mjs merged 4 commits intomjs:masterfrom
mjs merged 4 commits intomjs:masterfrom
Conversation
Contributor
|
Would it also make sense to update |
Contributor
Author
Good point. Added to workflow and updated docs. |
Owner
|
Thank you very much for this - an excellent change. Would you be able to address the black formatting issue? I'll then get this merged. |
Contributor
Author
|
Done |
Owner
|
Thanks! There's still a flake8 issue (unused import) but I'll merge and fix this myself. |
|
Any changes a release is made with this fix included? |
Owner
|
Release 3.1.0 has just been done and includes this fix. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #618 without needing to access undocumented Python
imaplibattributes that should not be modified, such asfile. Tested against Gmail IMAP TLS on Python 3.8, 3.13, and 3.14 using this test scriptSee also
python/cpython#142307
seanthegeek/mailsuite#15
domainaware/parsedmarc#636