chore: remove pop_with_default() function#532
Merged
mjs merged 1 commit intomjs:masterfrom Aug 27, 2023
Merged
Conversation
In current Pythons we can use `dict.pop(key, default)` Also converted some `**kwargs` to two named arguments with defaults.
Contributor
|
Which current Pythons ? |
Contributor
Author
All the ones that are supported by the current version of |
Contributor
Ok thanks, I should have known |
Contributor
Author
|
As a bit of trivia. It was added in Python 2.3. https://docs.python.org/2.7/library/stdtypes.html#mapping-types-dict |
mjs
approved these changes
Aug 27, 2023
Comment on lines
-1724
to
-1727
| def _command_and_check(self, command, *args, **kwargs): | ||
| unpack = pop_with_default(kwargs, "unpack", False) | ||
| uid = pop_with_default(kwargs, "uid", False) | ||
| assert not kwargs, "unexpected keyword args: " + ", ".join(kwargs) |
Owner
There was a problem hiding this comment.
I think at some point kwargs was passed down to other calls but not any more so what you've done makes much more sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current Pythons we can use
dict.pop(key, default)Also converted some
**kwargsto two named arguments with defaults.